GHSA-p498-v437-472g @humanfs/node: Recursive copy follows symlinks and copies files from outside the source tree - #1119
Open
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@humanfs/node](https://github.com/humanwhocodes/humanfs/tree/HEAD/packages/node) from 0.16.7 to 0.16.8. - [Release notes](https://github.com/humanwhocodes/humanfs/releases) - [Changelog](https://github.com/humanwhocodes/humanfs/blob/main/packages/node/CHANGELOG.md) - [Commits](https://github.com/humanwhocodes/humanfs/commits/node-v0.16.8/packages/node) --- updated-dependencies: - dependency-name: "@humanfs/node" dependency-version: 0.16.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
vharseko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@humanfs/nodefrom 0.16.7 to 0.16.8 inopenam-ui-js-sdk(GHSA-p498-v437-472g, CWE-22, CVSS 4.0 5.7 medium, patched in 0.16.8). The bump carries@humanfs/core0.19.1 -> 0.19.2 and adds@humanfs/types0.15.0, which the fixed release now needs at runtime.copyAll()handed every non-directory entry tocopy(), which delegates tofs.promises.copyFile()- and that dereferences symlinks. A symlink planted inside an attacker-controlled source tree therefore made a recursive copy read its target and write the contents into the destination, pulling in any file readable by the process from outside the tree being copied. The same applied tocopy()when the source path itself was a symlink. 0.16.8 copies symlinks as symlinks in both.Scope in OpenAM:
@humanfs/nodeis a dev-only transitive dependency ofeslint@10.7.0(config file loading), reached fromopenam-ui/openam-ui-js-sdkalone - it is not part of any runtime dependency tree and does not ship in the WAR. Linting never performs a recursive directory copy, so nothing in the build was exploitable; this keeps the toolchain clean of the advisory.Verified:
package.jsonedit needed -eslintrequires@humanfs/node@^0.16.6and 0.16.8 satisfies itintegrityhashes matchnpm view <pkg> dist.integrityfor@humanfs/node@0.16.8,@humanfs/core@0.19.2and@humanfs/types@0.15.0openam-ui/openam-ui-js-sdk/package-lock.jsonis the only lock file in the repository that resolves@humanfs/node, so no sibling module is left on the vulnerable versionUpstream: release notes - changelog - 22bbaa4 (symlink fix) - 956ce7a (ship type deps at runtime)
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)