-
-
Notifications
You must be signed in to change notification settings - Fork 12
Pick up the three things the rebase left behind #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
openipc-ai
wants to merge
2
commits into
feat/ia-cutover
Choose a base branch
from
fix/missed-from-snapshot
base: feat/ia-cutover
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,11 @@ | |
| <header> | ||
| <h2><%= t('title.openwall') %></h2> | ||
| <p><%=t('.subtitle') %></p> | ||
| <%# The wall is in the navigation and the footer now, so it gets visitors who | ||
| have not seen it before and cannot tell from a grid of stills whether | ||
| these were collected or volunteered. Two days is the retention | ||
| PurgeImagesJob::RETENTION actually enforces. %> | ||
| <p class="text-body-secondary small" style="max-width: 70ch"><i class="bi bi-camera-video me-1"></i><%= t('.intro_html') %></p> | ||
|
Comment on lines
+14
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2. Two-day deletion overpromised The intro says images are deleted after two days, but the two-day constant is only a cutoff for a once-nightly purge, so snapshots can remain published for nearly three days even when cron succeeds and longer when it fails. This makes the new user-facing retention assurance stricter than the behavior actually implemented. Agent Prompt
|
||
| </header> | ||
|
|
||
| <div class="row row-cols-1 row-cols-md-2 row-cols-xl-3 g-3 mb-4"> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'test_helper' | ||
|
|
||
| # The pages that predate the relaunch and survived it. | ||
| # | ||
| # They are the ones nobody thinks about, and they render through the layout, | ||
| # navbar and footer that the relaunch rewrote -- so a mistake in any of those | ||
| # shows up here first, or not at all. Six of these were served by the app and | ||
| # rendered by no test at all before this file. | ||
| class LegacyPagesTest < ActionDispatch::IntegrationTest | ||
| # path => a string the page must contain, so the test fails on an empty or | ||
| # wrong render rather than merely on a non-200. | ||
| PAGES = { | ||
| '/green_life' => 'green_life', | ||
| '/merchandise' => 'merchandise', | ||
| '/our-team' => 'our_team', | ||
| '/stages-of-firmware-development' => 'stages_of_firmware_development', | ||
| '/utilities' => 'utilities', | ||
| '/web-interface' => 'web_interface', | ||
| '/majestic-endpoints' => 'majestic_endpoints', | ||
| '/tools/firmware-partitions-calculation' => 'firmware_partitions_calculation', | ||
| '/tools/high-resolution-timer' => 'high_resolution_timer', | ||
| '/tools/qr-code-generator' => 'qr_code_generator' | ||
| }.freeze | ||
|
|
||
| PAGES.each do |path, key| | ||
| test "#{path} renders" do | ||
| get path | ||
|
|
||
| assert_response :success | ||
| assert_includes response.body, I18n.t("pages.#{key}.title"), | ||
| "#{path} rendered without its own title" | ||
| assert_no_match(/translation missing/i, response.body) | ||
| end | ||
| end | ||
|
|
||
| # These keep the layout's wrapper, unlike the relaunched pages. Asserting it | ||
| # here pins the other side of the content_for(:fullwidth) switch against the | ||
| # pages that actually depend on it. | ||
| test 'they render inside the layout wrapper' do | ||
| PAGES.each_key do |path| | ||
| get path | ||
|
|
||
| assert_not_empty css_select('main > div.container.mb-4'), "#{path} lost the wrapper" | ||
| end | ||
| end | ||
|
|
||
| # Every one of them renders the rewritten navbar and footer. | ||
| test 'they carry the navigation and the footer' do | ||
| PAGES.each_key do |path| | ||
| get path | ||
|
|
||
| assert_not_empty css_select('nav.navbar a.navbar-brand'), "#{path} has no navbar" | ||
| assert_not_empty css_select('footer.site-footer'), "#{path} has no footer" | ||
| end | ||
| end | ||
|
|
||
| # The page advertised a single T-shirt three times: the same image, the same | ||
| # .shirt_1 keys and the same link, pasted into three cards. | ||
| test 'merchandise lists each product once' do | ||
| get '/merchandise' | ||
|
|
||
| assert_equal 1, response.body.scan('weededwords.com').size | ||
| end | ||
|
|
||
| # The wall says what it is. It is linked from the navigation and the footer | ||
| # now, so it gets visitors who cannot otherwise tell whether the images were | ||
| # collected or volunteered. | ||
| test 'the Open Wall explains itself' do | ||
| get '/open-wall' | ||
|
|
||
| assert_response :success | ||
| assert_includes response.body, I18n.t('snapshots.index.intro_html') | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Unverified upload consent claim
🐞 Bug≡ CorrectnessAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools