This repository was archived by the owner on Aug 31, 2026. It is now read-only.
chore: require Node 24 - #369
Closed
georgeglarson wants to merge 1 commit into
Closed
Conversation
georgeglarson
marked this pull request as ready for review
August 29, 2026 17:15
Contributor
|
🚦 CI is currently failing on this PR's latest commit. Please fix the failing checks before OpenHands reviews it - this is re-checked automatically once you push a new commit. (A maintainer can also request This is an automated check - no AI was used to generate this comment. |
6 tasks
The package declares no engines field, so the implicit contract is "runs on whatever Node you have". With CI on 24 that is wider than anything gets tested, and a consumer on an untested runtime is better off seeing it at install than at connect(). Not marked breaking: the maintainer's call is that dropping 22 is not a breaking change for this package, since 24 is what gets built. Under release-please a chore carries no version event, so the field ships with whatever release comes next. Pairs with OpenHands#368, which moves CI onto 24. That one can land without this.
georgeglarson
force-pushed
the
feat-node-24-engines
branch
from
August 29, 2026 22:51
1114cb6 to
fe2aa88
Compare
github-actions
Bot
added
type: chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
Tests are human confirmed.
Why
Follows the Node 24 conversation in #proj-agent-canvas on 2026-08-29:
package.jsondeclares noenginesfield, so the package promises to run anywhere. It still runs on 22.12, and the suite passes there in #370's CI. So this is not fixing a false claim, it is narrowing the promise to what actually gets tested once #368 lands.Node 20 reached EOL on 2026-04-30, Node 22 runs to 2027-04-30. Kept separate from #368 so the declaration is a decision on its own rather than a line buried in a CI chore.
Summary
engines: { "node": ">=24" }topackage.json. Three lines, no other change.Issue Number
No issue filed. Requested in Slack, quoted above.
How to Test
Green on Node 24.20.0: 18 suites, 309 tests, 0 lint errors.
Consumer-side behaviour is the actual subject, and it is advisory rather than enforced. Packed the tarball and installed it on Node 22.23.2: npm warns
EBADENGINEand installs anyway, refusing only underengine-strict. pnpm and yarn (berry) both install too, yarn with a warning.So this narrows the declared contract and gives people a signal. It does not break anyone's build the day it merges.
Video/Screenshots
Type
Notes
Not marked breaking: the maintainer's read is that dropping 22 isn't breaking here, since 24 is what gets built. The commit is a
chore, so release-please cuts no version event and the field ships with whatever release comes next. Close this if you'd rather set the floor differently. Nothing else depends on it.#368 moves CI to Node 24 and is a plain chore. It stands alone and can land whether or not this one does.