fix(ci): use AGENT_SERVER_SHA to avoid conflict with GitHub's default GITHUB_SHA#2816
fix(ci): use AGENT_SERVER_SHA to avoid conflict with GitHub's default GITHUB_SHA#2816
Conversation
… GITHUB_SHA GitHub Actions sets GITHUB_SHA to the merge commit for pull_request events. The step-level env override stopped working reliably with runner image ubuntu24/20260406.80. Use a custom variable name AGENT_SERVER_SHA to explicitly pass the PR head SHA to example scripts for Docker image tag resolution. This fixes the 5 docker/apptainer/remote-runtime example failures seen in the v1.17.0 release PR (#2812). Co-authored-by: openhands <openhands@all-hands.dev>
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
|
@OpenHands reviewed against main. I vaguely remember that I implemented a similar fix a while ago. Is this fix still necessary? If not, let's close this PR. |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
|
You're right — this fix is no longer necessary. Commit This PR can be closed. This comment was generated by an AI assistant (OpenHands). |
|
Closing — superseded by aabf407 on main. |
SummaryThe reviewer (@xingyaoww) asked whether this PR's fix was still necessary, recalling a similar fix was implemented previously. Answer: The fix in PR #2816 is no longer necessary. Commit
Actions taken:
No code changes were made — this was purely an investigation and PR closure. |
Summary
Fixes the 5 docker/apptainer/remote-runtime example failures seen in the v1.17.0 release PR (#2812).
Problem
GITHUB_SHAis a GitHub Actions built-in env var that defaults to the merge commit SHA forpull_requestevents. Therun-examples.ymlworkflow attempted to override it at step level with the PR head SHA, but this stopped working reliably with runner imageubuntu24/20260406.80(it worked onubuntu24/20260323.65used by v1.16.0).The result: example scripts resolved
os.getenv("GITHUB_SHA")to the merge commit SHA (a76b56b), but agent-server images were tagged with the head SHA (9e90afa). The images existed — the examples just looked for the wrong tag.Fix
Use a custom variable name
AGENT_SERVER_SHAthat doesn't conflict with GitHub's built-in. This is the same approachserver.ymlalready uses withSDK_SHA.Files changed
.github/workflows/run-examples.yml—GITHUB_SHA→AGENT_SERVER_SHAexamples/02_remote_agent_server/02_convo_with_docker_sandboxed_server.pyexamples/02_remote_agent_server/03_browser_use_with_docker_sandboxed_server.pyexamples/02_remote_agent_server/04_convo_with_api_sandboxed_server.pyexamples/02_remote_agent_server/05_vscode_with_docker_sandboxed_server.pyexamples/02_remote_agent_server/08_convo_with_apptainer_sandboxed_server.pyexamples/02_remote_agent_server/09_acp_agent_with_remote_runtime.pyContext
Full diagnosis in PR #2812 comments.
This PR was created by an AI assistant (OpenHands) on behalf of the user.
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:f5440c3-pythonRun
All tags pushed for this build
About Multi-Architecture Support
f5440c3-python) is a multi-arch manifest supporting both amd64 and arm64f5440c3-python-amd64) are also available if needed