Skip to content

chore: cargo update and cleanup of blotated crates - #321

Merged
Ghoul4500 merged 2 commits into
OpenGamingCollective:mainfrom
scardracs:fix/cargo-update
Aug 19, 2026
Merged

chore: cargo update and cleanup of blotated crates#321
Ghoul4500 merged 2 commits into
OpenGamingCollective:mainfrom
scardracs:fix/cargo-update

Conversation

@scardracs

Copy link
Copy Markdown
Contributor

Description

In the years we picked up more and more crates but some of these are bloated with unwanted, at least on our project, sub-crates. This PR is a means to cleanup these bloated crates while update the whole Cargo.lock (requested by Debian CI so I can't do much on it). The PR #314 is of the same family: clean up image processors maintaining only image as sole crate.

In my intention there would be even the x11 cleanup but that is something I can't decide alone so it will be, hopefully, handled in a future PR.

Tested Hardware & Environment

  • ASUS Laptop Model: G614PR
  • Linux Distribution: CachyOS
  • Kernel Version: 7.2-rc7

Verification and testing:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (cargo fmt --all -- --check)
  • My changes generate no new warnings (cargo clippy --all -- -D warnings/cargo check --all-targets)
  • New and existing unit tests pass locally with my changes (cargo test --all)
  • Cranky with 0 warning (cargo cranky)

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7aff56bb-5a3f-4374-8ed6-5e2f8c4e5cbb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b54164e5-08a5-4a20-b6b2-a1436f2e4673

📥 Commits

Reviewing files that changed from the base of the PR and between d46a24c and 45540ee.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • asus-shutdown/Cargo.toml
💤 Files with no reviewable changes (1)
  • asus-shutdown/Cargo.toml

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: cargo audit (Debian 13 / rustc 1.85)
  • GitHub Check: cargo build --workspace (Debian 13 / rustc 1.85)
🔇 Additional comments (2)
Cargo.toml (2)

43-43: LGTM!


57-58: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated notification and logging components for a leaner configuration.
    • Removed an unused platform dependency from the shutdown component.

Walkthrough

The manifests now use narrower feature selections for env_logger and notify-rust. The asus-shutdown crate no longer declares the rog_platform dependency.

Changes

Dependency cleanup

Layer / File(s) Summary
Manifest dependency updates
Cargo.toml, asus-shutdown/Cargo.toml
env_logger and notify-rust now disable default features and select explicit features. asus-shutdown removes its rog_platform path dependency.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 45540

This PR removes unwanted dependency crates and updates the Cargo.lock file without any identified correctness, security, availability, or deployment risk; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: neroreflex

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the Cargo dependency update and cleanup, which match the main changes.
Description check ✅ Passed The description explains the dependency cleanup, tested environment, verification steps, and the X11 work that remains out of scope.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Ghoul4500
Ghoul4500 merged commit ede5a39 into OpenGamingCollective:main Aug 19, 2026
3 checks passed
@scardracs
scardracs deleted the fix/cargo-update branch August 19, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants