Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
__init__.py
files (you can avoid this by using the__all__ = [foo, bar,]
dunder but since we don't really export any api in the__init__.py
that we would want to not pull in with a*
import I opted to just ignore those checks on all__init__.py
files)Literal[..]
works but flake8 does something to make it work, we may be able to getFloatQuanity
to do some magic to make it work the same.We should make this a required check since when pre-commit fails we either need to fix the errors or tell pre-commit to ignore the error if it is a false positive.
If things have settled enough, all the CI, docs, and pre-commit.ci should be required IMHO