Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some protocol updates: MDPs dict, vacuum check #43

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Conversation

hannahbaumann
Copy link
Contributor

@hannahbaumann hannahbaumann commented Sep 24, 2024

This PR addresses following issues:
#38: Have MDPs be a dictionary rather than a list of file handles
#40: Move vacuuum disallowed check to Protocol creation
#45: Set Interchange experimental env variable in protocol

@pep8speaks
Copy link

pep8speaks commented Sep 24, 2024

Hello @hannahbaumann! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 209:80: E501 line too long (86 > 79 characters)

Line 183:80: E501 line too long (82 > 79 characters)

Comment last updated at 2024-09-25 11:59:45 UTC

@hannahbaumann hannahbaumann linked an issue Sep 24, 2024 that may be closed by this pull request
@hannahbaumann hannahbaumann changed the title Have MDPs be a dictionary rather than a list of file handles Some protocol updates: MDPs dict, vacuum check Sep 24, 2024
@hannahbaumann hannahbaumann added this to the MVP milestone Sep 24, 2024
@hannahbaumann hannahbaumann linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (14ab594) to head (6f45c9d).
Report is 7 commits behind head on main.

Additional details and impacted files

@hannahbaumann hannahbaumann linked an issue Sep 25, 2024 that may be closed by this pull request
@hannahbaumann hannahbaumann merged commit 89fadea into main Sep 25, 2024
7 of 9 checks passed
@hannahbaumann hannahbaumann deleted the protocol_updates branch September 25, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants