-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
towards v1.0 #64
towards v1.0 #64
Conversation
* Update visualisation of molecules to 2D * parallelization bug fix * example: adding charge data * widget scroll sensitivity improvement. * bug fix clusteredNetworker understands now own default. * Changes: * analysis: * minor modifications on cycle analysis (only check for cylce of size 3 per default) * make delete more performant, by deleting multiple transformations/components at once if wanted. * adding graph cost and efficiency * jnbs: *Adding text to Example JnB. network -planners: * minor refactors * display fix, correct number of expected edges. * minor text improvments * Update widget.py passing variable trough from top to bottom. * Changes: - Notebook improvements, more documentation, black formatting - improving network generator documentation - vscode -> gitignore * applied black to code. * adding pre-commit and dependencies * fixing konnektor_networks.ipynb. * fixing konnektor_networks.ipynb. * fixing konnektor_example.ipynb. * Update pyproject.toml * fix networks.ipynb * fix widget --------- Co-authored-by: Julicancode <[email protected]>
* parallelization bug fix * example: adding charge data * widget scroll sensitivity improvement. * bug fix clusteredNetworker understands now own default. * Changes: * analysis: * minor modifications on cycle analysis (only check for cylce of size 3 per default) * make delete more performant, by deleting multiple transformations/components at once if wanted. * adding graph cost and efficiency * jnbs: *Adding text to Example JnB. network -planners: * minor refactors * display fix, correct number of expected edges. * minor text improvments * Changes: - Notebook improvements, more documentation, black formatting - improving network generator documentation - vscode -> gitignore * applied black to code. * adding pre-commit and dependencies * make ipycytoscape optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the aim is for this to be merged and cut a 1.0. In that spirit I'm going to block this PR over user and developer documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block not approve
@IAlibay |
changed jupyter notebooks.
@IAlibay here are the jupyter notebook changes contained now :) |
* adding intermediate generator to konnektor * adding abstract class gufe style, making intermediator tokenizable. --------- Co-authored-by: LindeSchoenmaker <[email protected]>
This PR lifts Konnektor to v1.0
it contains a lot of improvements and bug fixes on visualizations, network planners and documentation.
additionally it introduces a precommit hook for black