-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement task restart policies #280
base: main
Are you sure you want to change the base?
Commits on Jul 16, 2024
-
Added placeholder tests for proposed methods
* Test: test_add_task_restart_policy_patterns * Test: test_get_task_restart_policy_patterns * Test: test_remove_task_restart_policy_patterns * Test: test_clear_task_restart_policy_patterns * Test: test_task_resolve_restarts
Configuration menu - View commit details
-
Copy full SHA for 7f752b3 - Browse repository at this point
Copy the full SHA 7f752b3View commit details -
Added models for new node types
* TaskRestartPattern * TaskRestartPolicy * TaskHistory
Configuration menu - View commit details
-
Copy full SHA for dd8f0e9 - Browse repository at this point
Copy the full SHA dd8f0e9View commit details
Commits on Jul 17, 2024
-
Updated new GufeTokenizable models in statestore
* Removed TaskRestartPolicy and TaskHistory * Added Traceback
Configuration menu - View commit details
-
Copy full SHA for da17e45 - Browse repository at this point
Copy the full SHA da17e45View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7f63d4 - Browse repository at this point
Copy the full SHA b7f63d4View commit details
Commits on Jul 18, 2024
-
Added validation and unit tests for storage models
* TaskReturnPattern: Confirm that the input pattern is a string type and that it is not empty. * Traceback: Confirm that the input is a list of strings and that none of them are empty.
Configuration menu - View commit details
-
Copy full SHA for 6a167f1 - Browse repository at this point
Copy the full SHA 6a167f1View commit details
Commits on Jul 22, 2024
-
Added
taskhub_sk
toTaskRestartPattern
Similar to `TaskHub`s, the `TaskRestartPattern` needs additonal hashed data to uniquely identify it as a Neo4j node (via the gufe key). The unit tests have been updated to reflect this change.
Configuration menu - View commit details
-
Copy full SHA for a10e235 - Browse repository at this point
Copy the full SHA a10e235View commit details -
Added
statestore
methods for restart patterns`statestore` methods have been added to modify the database state: * add_task_restart_patterns * remove_task_restart_patterns * get_task_restart_patterns Tests were added for each method in the integration tests for the statestore.
Configuration menu - View commit details
-
Copy full SHA for b99d8ef - Browse repository at this point
Copy the full SHA b99d8efView commit details
Commits on Jul 25, 2024
-
Added APPLIES relationship when adding pattern
The `add_task_restart_patterns` method now establishes the APPLIES relationship between the each new pattern and all Tasks ACTIONED on the corresponding TaskHub. Added testing for creation of the APPLIES relationship, asserting the number of created connections over multiple TaskHubs and Tasks. Further subdivided the test classes. Additionally added a `set_task_restart_patterns_max_retries` method for updating the max_retries of a TaskRestartPattern.
Configuration menu - View commit details
-
Copy full SHA for 39f9868 - Browse repository at this point
Copy the full SHA 39f9868View commit details
Commits on Jul 26, 2024
-
Establish APPLIES when actioning a Task
"actioning" a Task on a TaskHub with preexisting TaskRestartPatterns created the APPLIES relationship between them with a num_retries value of 0. This behavior is tested in the test_action_task function in the statestore.
Configuration menu - View commit details
-
Copy full SHA for 988155f - Browse repository at this point
Copy the full SHA 988155fView commit details -
Canceling a Task removes the APPLIES relationship
When an actioned Task is canceled and also has an APPLIES relationship with a TaskRestartPattern, APPLIES is removed between the two nodes. Removed org, project, and campaign fields since they are not necessary for the APPLIES relationship.
Configuration menu - View commit details
-
Copy full SHA for d3f25f8 - Browse repository at this point
Copy the full SHA d3f25f8View commit details
Commits on Aug 1, 2024
-
Task status changes affect APPLIES relationship
Setting an actioned Task status to the following statuses now removes the APPLIES relationship from attached TaskRestartPatterns: * complete * invalid * deleted NOTE: tests have not been added for this yet
Configuration menu - View commit details
-
Copy full SHA for 510ae66 - Browse repository at this point
Copy the full SHA 510ae66View commit details
Commits on Aug 4, 2024
-
Tests for Task status change on APPLIES
Confirming that changing the status of an actioned Task to any of the following removes the APPLIES relationship: * complete * invalid * deleted
Configuration menu - View commit details
-
Copy full SHA for 2310fd5 - Browse repository at this point
Copy the full SHA 2310fd5View commit details