Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Challenges amended with new COVID API and markdown formatting #400

Merged

Conversation

bentleycook
Copy link
Contributor

This changeset includes:

  • Amended the COVID challenge to use a different API as the original appears to no longer be working.
  • Markdown formatting likes for code blocks to include the language.
  • Moved up the installation of http adaptor to the first challenge that expects a user to use it.
image

- Amended the COVID challenge to use a different API
as the original appears to no longer be working.
- Markdown formatting likes for code blocks to include
the language.
- Moved up the installation of http adaptor to the first
challenge that expects a user to use it.
@bentleycook
Copy link
Contributor Author

Some thoughts - the old COVID API keeps throwing 5XX and returning Cloudflare's gateway timeout view. I'm guessing it is gone for good.

The API I included in this PR is very US-centric, unfortunately. It isn't obvious to me what a compelling task for a user could be with this dataset, so I left it kind of open-ended.

@mtuchi mtuchi self-requested a review February 13, 2024 06:32
@mtuchi
Copy link
Contributor

mtuchi commented Feb 13, 2024

Thanks @bentleycook , We were discussing similar approach in here #393, I will review this and merge

@mtuchi mtuchi changed the base branch from main to version February 13, 2024 06:33
Copy link
Contributor

@mtuchi mtuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes looks good, We had similar suggestion on #393

@mtuchi mtuchi changed the base branch from version to 393-cli-covid-19 February 13, 2024 07:18
@mtuchi mtuchi merged commit e7d87f9 into OpenFn:393-cli-covid-19 Feb 13, 2024
1 check failed
@mtuchi mtuchi mentioned this pull request Feb 13, 2024
2 tasks
mtuchi pushed a commit that referenced this pull request Mar 21, 2024
- Amended the COVID challenge to use a different API
as the original appears to no longer be working.
- Markdown formatting likes for code blocks to include
the language.
- Moved up the installation of http adaptor to the first
challenge that expects a user to use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants