Improved numerical methods for the vacuum module#190
Draft
jhalpern30 wants to merge 15 commits intodevelopfrom
Draft
Improved numerical methods for the vacuum module#190jhalpern30 wants to merge 15 commits intodevelopfrom
jhalpern30 wants to merge 15 commits intodevelopfrom
Conversation
…efore inverting the system
… in memory. Works for 1 thread, but currently some nondeterministic results in multi-threading
…ion, some pooling optimizations
…th a small kernel subbranch for fused or not
…ropagating it through the vacuum module
…r solovev already)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the title, speeding up the vacuum code and making it use less memory. Primarily targeting 3D, but we'll see if any of these help 2D as well
The main goal of this PR is to project the full collocation matrix into Fourier space, making the vacuum response calculation go from O(N^3) compute and O(N^2) memory to O(P^3) compute and O(NP) memory, where N is the physical collocation resolution and P is the number of modes