Closed
Conversation
Task 1 - Add 'imas' input type to equilibrium inputs: - Add read_imas() function to ReadEquilibrium.jl that extracts psi(R,Z), F(psi), P(psi), q(psi) from an IMAS data dictionary (dd) and returns a DirectRunInput for the existing direct solver - Add 'imas' dispatch case to setup_equilibrium() in Equilibrium.jl Task 2 - Declare IMASdd.jl as a package dependency: - Add IMASdd (uuid: c5a45a97-b3f9-491c-b9a7-aa88c3bc0067) to Project.toml [deps] and [compat] (>=8) - Correct import from IMAS to IMASdd in Equilibrium.jl Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…ts to dd Tasks completed: - Task 1: add read_imas() to ReadEquilibrium.jl — loads full plasma equilibrium (psi, q, p, F, dV/dpsi, 2D flux map) from an IMASdd.dd, with COCOS 11→2 conversion (factor 1/2pi for psi, 2pi for q) - Task 2: register IMASdd and EFIT as dependencies in Project.toml - Task 3: add DCON.Main(path, dd) overload in Main.jl so DCON can be initialised directly from a dd without reading equil.toml from disk - Task 4: add test/runtests_imas.jl — 27 automated tests covering the read_imas round-trip (gEQDSK→dd→JPEC matches gEQDSK→JPEC to <1%) and write_imas correctness; registered in runtests.jl - Task 5: add WriteImas.jl with write_imas() — writes DCON energy eigenvalues and toroidal mode numbers into dd.mhd_linear after every IMAS-path run Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
|
replaced with #183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress