Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and bug fixes to HD for rc-3.5.1 #1806

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

luwang00
Copy link
Contributor

Feature or improvement description
This PR fixes the bugs identified in Issue #1446. It also updates the wave-radiation convolutional integral to be 2nd order. Note that all these issues were already addressed in version 4.0 in the dev and dev-unstable-pointers branches.

Related issue, if one exists
This PR fixes the bugs identified in Issue #1446.

Impacted areas of the software
HydroDyn

Additional supporting information
This is a backport of the updates already made in version 4.0 in the dev and dev-unstable-pointers branches. It might cause merge conflicts if rc-3.5.1 is to be merged back into dev or dev-unstable-pointers.

Test results, if applicable
r-test results will need to be updated.

Release checklist:

  • Create a merge commit in r-test and add a corresponding tag

@andrew-platt
Copy link
Collaborator

Regression test changes:

hd_OC3tripod_offshore_fixedbottom_wavesirr

Screenshot 2023-10-16 at 12 32 09 PM
Member crossing SWL

hd_5MW_OC4Semi_WSt_WavesWN

Screenshot 2023-10-16 at 12 36 41 PM
Change in radiation force. Same for py_hd_5MW_OC4Semi_WSt_WavesWN case.

5MW_OC3Trpd_DLL_WSt_WavesReg

Screenshot 2023-10-16 at 12 40 53 PM
Similar to the standalone tripod case, the HydroFxi (and other HydroF* forces) changed. Morison node outputs also change slightly.

5MW_OC3Mnpl_DLL_WTurb_WavesIrr

Screenshot 2023-10-16 at 12 49 20 PM
Small changes in hydro forces due to Morison changes.

5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti & 5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti_py

Screenshot 2023-10-16 at 12 52 50 PM
Small changes in hydro forces led to changes in platform motion and minor changes to controller response
Screenshot 2023-10-16 at 12 54 07 PM

5MW_OC3Spar_DLL_WTurb_WavesIrr & 5MW_OC3Spar_DLL_WTurb_WavesIrr_py

Screenshot 2023-10-16 at 12 58 24 PM
Very small changes in overall Hydro forces and subsequent motion.

5MW_OC4Semi_WSt_WavesWN & 5MW_OC4Semi_WSt_WavesWN_py & StC_test_OC4Semi

Screenshot 2023-10-16 at 1 01 00 PM
Small motion changes in all 3 cases.

MHK_RM1_Floating

Screenshot 2023-10-16 at 1 07 03 PM
Due to radiation or members crossing SWL.

@andrew-platt andrew-platt marked this pull request as ready for review October 16, 2023 19:27
@andrew-platt andrew-platt merged commit 3409efe into OpenFAST:rc-3.5.1 Oct 16, 2023
19 checks passed
@luwang00 luwang00 mentioned this pull request Oct 20, 2023
19 tasks
@luwang00 luwang00 deleted the rc-3.5.1 branch November 2, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants