Updates and bug fixes to HD for rc-3.5.1 #1806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR fixes the bugs identified in Issue #1446. It also updates the wave-radiation convolutional integral to be 2nd order. Note that all these issues were already addressed in version 4.0 in the
dev
anddev-unstable-pointers
branches.Related issue, if one exists
This PR fixes the bugs identified in Issue #1446.
Impacted areas of the software
HydroDyn
Additional supporting information
This is a backport of the updates already made in version 4.0 in the
dev
anddev-unstable-pointers
branches. It might cause merge conflicts ifrc-3.5.1
is to be merged back intodev
ordev-unstable-pointers
.Test results, if applicable
r-test results will need to be updated.
Release checklist: