This reverts commit 5657f25.

…date

Update WAMIT .hst input file and baselines for floating MHK r-test

Remove TurbineType parameter

…date

Update HydroDyn input file and baselines for floating MHK r-test

The input arrays for Lidar to ServoDyn get allocated in ServoDyn.f90, and again in BladedInterface_EX.f90.  This double allocation causes issues for many compilers.  The logic behind all this really should be looked at in more detail, but since the Lidar module in InflowWind will be superceeded by LidarSim in release 4.0.0, I'm not going to sort the logic right now.

Affected arrays:
    u%LidSpeed
    u%MsrPositionsX
    u%MsrPositionsY
    u%MsrPositionsZ

Thanks  to @foxton9 for reporting the issue, and proposing the fix!

This was reported in issue OpenFAST#1484

[BugFix] ServoDyn inputs for Lidar allocated twice, and a few other minor issues

[BugFix] HD wave visualization with 2nd order waves

- I don't really like these parameters in NWTC Library, but they seem to be used in many different modules, so that's the easiest place for now
- some of the IF statements had redundant ELSEIF  instead of just ELSE, so I simplified them from (IF A ... ELSEIF NOT A...) to (IF A ... ELSE...)

In the past, the only way to build openfastlib as a shared library
was to set -DBUILD_SHARED=ON. This library is now always built as shared
but many users still set BUILD_SHARED which causes all module libraries
to be created as shared which means that all must be dynamically loaded
at run time. This commit changes the CMakeLists.txt files to build all
module libs as STATIC regardless of BUILD_SHARED. This means that all
module libraries will be statically linked into openfast, openfastlib
and FAST.Farm which should improve performance and reduce complexity

ED bug fix from prev commit

903cf07

- If user requests too many nodal outputs, the max number of outputs will be generated instead of none (as done previously)
- call generic LAPACK_GEMM routines instead of writing LAPACK_DGEMM
- return after error on Init_MiscVars to prevent issues when writing summary file
BD: Explicitly initialize new InitInp in driver

MHK: add parameters for readability

Looks like it got commited accidentally on a rebase command....

Make CMake module libs STATIC

Initial AeroMap changes for ElastoDyn and BeamDyn

The last revision had the incorrect case for the CMake variable,
so the flag wasn't being added

We added the hub point to AWAE at the center of the grid now that IfW calculates the disk average velocity every time IfW_CalcOutput gets called. But this point needs to be shifted by the turbine position so it is in the box.

This will all change in 4.0.0 when we switch to pointers for all this and don't call IfW_CalcOutput directly anymore.

Fix adding OpenMP flags to CMAKE_Fortran_FLAGS

FF: fix bug with Mod_AmbWind=3 -- hub point wasn't shifted.

This is a hack fix -- the logic really should be improved elsewhere in the code for checking if any blades are output.  However, we don't actually have logic in place yet for only outputting certain blades.

This was causing issues in the linearization as the reported windspeed was on the order of 1E+38, which did not format correctly in the `.lin` output file

ED/AD: fix segfault when BldNd_BladesOut==0

…t from driver

[BuFix] InflowWind was not setting InitOut MWS data.

…#1658)

…AST#1657)

AD: Adding rtest for TailFin polar-based model

The TurbSim documentation incorrectly specified that the wind direction colum in the user profiles was the meteorological wind direction (counter-clockwise from above). However, it was actually implemented as an angle, clockwise from above.

TurbSim documentation

In the BeamDyn driver, and likely in the glue-code, if the blade was
initially rotated then an initial strain was introduced which produced
forces when no loads or gravity had been applied. The cause was
traced to the calculation of R0 (initial rotation) at the quadrature
points which was interpolated via the shape functions from the
element nodal rotations. The shape function interpolation is not
exact and introduced strains on the order of 1e-7, but with the large
stiffness of the blade, forces of 6200 N could be produced at the root
for the IEA 15MW blade. This was resolved by directly calculating
the quadrature point initial rotations in uu0(4:6) via interpolated
tangent and twist, which are well behaved. This was only a problem for
non-straight blades such as the IEA 15MW.

This commit also fixes a bug where the parameter UsePitchAct
wasn't initialized from the input file until after it was used in
SetOutParam. The initialization has been moved to SetParameters.

Resolve BeamDyn initial strain for rotated blade

The TurbSim documentation incorrectly specified that the wind direction column in the user profiles was the meteorological wind direction. However, it was actually implemented as an angle, counter-clockwise from above.

TurbSim documentation

When building the Simulink MEX file with CMake on Linux, the resulting
shared library had unresolved symbols. This was due to the order in
which the static libraries were specified in simulink/CMakeLists.txt.
The GCC linker does one pass over the libraries and notes unresolved
dependencies which can only be resolved by the succeeding libraries.
This means that the most generic libs (like NWTC-Library) need to
appear at the end of the list.

Instead of leaving it up to the user to get the order right, the
simulink/CMakeLists.txt file has been updated to link the libraries
twice.

The same issue occured when using USE_LOCAL_STATIC_LAPACK
in that the BLAS libraries were linked before LAPACK so there
were unresolved symbols. This has been fixed by reversing the order.

Also, the OpenFOAM libraries have been marked as STATIC.

Fix missing symbols for Simulink and  LAPACK build

The time handling for G4D time index finding was a mix of single and double precision.  This could lead to finding the wrong index in a G4D wind grid passed from FF to an OpenFAST turbine, in which case the index might be outside the G4D box that was passed.  We think this can occur with a long simulation of 4,200 s, with an OpenFAST DT of 0.0378 s, which resulted in a time index out of bounds at time 4132 seconds.

Changed the OpenFOAM module name to ExternalInflow.

There was a bug where the modulo operation to wrap back to the beginning
of the wind file didn't work correctly, previously noted in issue OpenFAST#471.
This seemed to come back due to some changes in the IfW refactor.
The ifw_HAWC regression test was added to catch this and other IfW
changes in the future.

…lInflow

ExternalInflow: rename files, change names in files

This commit specifies Python_ROOT_DIR for each github action
since each Job may have a different version of Python and a
different path to the executable. By specifying Python_ROOT_DIR
each Job should get a valid path.

…BoxTime

[BugFix] change time handling to double precision for G4D timestep index

* AD: more bldnd outputs channels, more documentation of future bem
* AD: renaming psi as psi_s
* AD: mode outputs channels
* AD: more comments in BEM code
* AD: documenting coordinate systems
* AD: implementing additional outputs for Buoyancy
* AD: using i instead of g in AeroDyn regular outputs
* AD: wrapped optional argument call to avoid passing them if not provided
* AD: update of coordinate system documentation
* AD: change comments polar (p) -> local-polar (l)
* AD: links were swapped in documentation

* RTest: update of lin file comparison
* Update of lin baselines
* RTest: adding freq and damp comparisons for lin tests
* RTest: BD_Free_Free case is difficult for damping comparison

…penFAST#1695)

* Rename `OpenFOAM` to `ExternalInflow` in Visual Studio project

* VS project: MAP

For some reason, the Registry didn't run properly in the MAP dll project with MAP_Regstiry.txt. Since the MAP.h file it is trying to generate is in the repository and it gets generated in the FASTlib project, I decided to remove it here.

Remove deleted variables BlFB and BlMB from AeroDyn_AllBldNdOuts_IO

This branch is to modify the workflow to add tests for the build of the Matlab Simulink interface.

Unit test for Matlab Simulink interface.

Use environment variable to get workspace root

Added Simulink test run

Rename simulink test and add step to set up Matlab.

Change class name to match file name.

Ensure variables are available to Simulink model

Actually build FAST_SFunc before testing

Add dependencies

…into dev

Since the trim solution seems to always converge on the first step when NLinTimes == 1 (see OpenFAST#857), I added a warning and overwrite NLinTimes to be 2 instead. This should be removed when OpenFAST#857 is fixed

Remove references to openfoam library as that module has been removed

Add references to external inflow module libs

update another reference from openfoam to  externalinflow

Add missing seastlib

Linear trim solution: add error check

Update r-tests

Disabling this test case for now so PR OpenFAST#1709 can be completed as it is
holding up development. The test passes locally, but takes >1500 sec
to run on GH Actions which causes it to fail with a timeout. A task has
been created in GH so this gets fixed before 4.0.0 is released.

See if 5MW_OC4Semi_Linear will run faster when built using OpenBLAS