InflowWind Flow Field fails to calculate AvgVel for large wind files when using Intel Compiler #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit specifies Python_ROOT_DIR for each github action since each Job may have a different version of Python and a different path to the executable. By specifying Python_ROOT_DIR each Job should get a valid path.
See if 5MW_OC4Semi_Linear will run faster when built using OpenBLAS
Trying to resolve issue with regression test failure when it was previously passing
This reduces the number of parallel linearization regression tests in GH actions in an attempt to keep the actions from failing
When using the Intel compiler, summing along a dimension of an array creates a temporary copy which can be very large for 3D grid flow fields. The Intel compiler tries to allocate this temporary array on the stack, but it's too large and fails.
deslaughter
force-pushed
the
ifw-velavg
branch
from
994cf5b
to
8e7e0b9
Compare
deslaughter
requested review from
andrew-platt
and removed request for
ebranlard
andrew-platt
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
This fixes an issue in InflowWind Flow Field where calculating the average velocity and average acceleration would create a temporary array too large for the stack when using the Intel Compiler. This PR also cherry picks some improvements to Github Actions which were included in the
devbranch but not inrc-3.5.1.Related issue, if one exists
#1764
Impacted areas of the software
IfW_FlowField.f90)automated-dev-tests.yml)Test results, if applicable
This PR disables the
Fake5MW_AeroLin_B1_UA4_DBEMT3regression test because it was intermitently failing on Github Actions which does not appear to be an issue in thedevbranch and is not related to the code itself.