Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD: UA: no linearization for UA states that are off #1716

Merged
merged 12 commits into from
Aug 23, 2023

Conversation

ebranlard
Copy link
Contributor

@ebranlard ebranlard commented Aug 3, 2023

This pull request is ready to be merged

Feature or improvement description
This pull request:

  • Uses a 2nd order backward difference Newton scheme to perform the time integration of the UA states (should be more robust)
  • Does not select UA states that are off for the linearization (results in less states and nicer A matrices (less zeros))

Also:

  • Performs an extrap interp of inputs before updating the states, and perform checks on the inputs to make sure they are consistent and dont introduce division by zero
  • Uses smaller increments for the linearization of UA continuous states (dx)
  • The python script for comparison of lin files aborts only after checking all the lin files, and therfore displays all the errors that occurs (and on which module lin file).

Impacted areas of the software
AeroDyn, UnsteadyAerodynamics

Additional supporting information

Test results cahnge

  • OpenFASTLin: Fake5MW*: the size of the states matrices is now changed. The change of dx slightly affects the lin results as well. No changes in frequencies and damping.

@ebranlard ebranlard changed the title AD: UA: no linearization for UA states that are off and stiff time integrator AD: UA: no linearization for UA states that are off Aug 23, 2023
@ebranlard ebranlard merged commit 4ffcb82 into OpenFAST:dev Aug 23, 2023
21 checks passed
@ebranlard ebranlard deleted the f/ua-nodes-bdf2 branch August 25, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants