-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deleted variables BlFB and BlMB from AeroDyn_AllBldNdOuts_IO #1700
Conversation
I'm not sure why |
I was confused by that, as well as the OpenFOAM_Types changes. |
@@ -1545,7 +1544,7 @@ SUBROUTINE BldNdOuts_SetOutParam(BldNd_OutList, p, p_AD, ErrStat, ErrMsg ) | |||
endif | |||
|
|||
! The following are valid only for BEMT/DBEMT | |||
if (p_AD%WakeMod == WakeMod_BEMT) then | |||
if (p_AD%WakeMod /= WakeMod_BEMT) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing that change :)
Thanks for doing that. I'm not sure about those types indeed. |
@bjonkman, I'm thinking the same thing: it is very likely a bad merge I did at some point in the history. I'm tempted to leave it as is for now and fix it right before release. The |
@andrew-platt it looks like the |
This pull request is ready to be merged.
During debugging of the buoyancy feature, the variables BlFB and BlMB were removed and replaced with the line meshes BladeBuoyLoad%Force and BladeBuoyLoad%Moment. At the time, this was not updated in AeroDyn_AllBldNdOuts_IO.f90. This pull request replaces the remaining instances of BlFB and BlMB.