Return the "file not found" error for ecx_FOEread() through wkc #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "file not found" error is the most significant error that can be returned from the above function as it can affect and guide the work flow, so it makes sense to have it returned in some way. Since the same error has already been processed and returned in the ecx_FOEwrite() function, there is no reason not to process it and return it in the ecx_FOEread() function in the exact same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "file not found" error is the most significant error that can be returned from the above function as it can affect and guide the work flow, so it makes sense to have it returned in some way. Since the same error has already been processed and returned in the ecx_FOEwrite() function, there is no reason not to process it and return it in the ecx_FOEread() function in the exact same way.
The good thing about this change is that it adds a lot of flexibility cheaply, since it doesn't require full support for all FoE errors.