Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to create relocatable CMake package (for linux and windows) #652

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Corrections to create relocatable CMake package (for linux and windows) #652

wants to merge 7 commits into from

Commits on Oct 17, 2022

  1. .gitignore update 

    .gitignore update for the sake of CLion environment
    @kutij
    kutij committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    a310c4b View commit details
    Browse the repository at this point in the history

  2. Usage of target_link_libraries instead of link_libraries for system libs 

    Now variable OS_LIBS contains the system libraries too and the wpcap/packet libs with correct build/install pathes (SoemConfig will inherit it)
    @kutij
    kutij committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    fd30df1 View commit details
    Browse the repository at this point in the history

  3. Unnecessary rows in target_include_directories commands 

    Only cleaning
    @kutij
    kutij committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    2d069eb View commit details
    Browse the repository at this point in the history

  4. CMake path in the package is unreasonably long

    @kutij
    kutij committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    ba3bcf5 View commit details
    Browse the repository at this point in the history

  5. Variables used only once are substituted

    @kutij
    kutij committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    0b81648 View commit details
    Browse the repository at this point in the history

  6. Usage of target_include_directories instead of include_directories 

    All of the requested libraries are listed in variable OS_INCLUDE (both the build and install pathes).

The headers in question are copied into the package.
    @kutij
    kutij committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    da54801 View commit details
    Browse the repository at this point in the history

  7. More versions of the libs (release/debug/Relwithdebinfo/minsizerel) c… 

    …an be in the package via postfixes

For windows, the VS toolset & platform is  also described (the config will link the appropriately one)
    @kutij
    kutij committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    e0432be View commit details
    Browse the repository at this point in the history