Bug with first slave with many PDOs and DC enabled. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[EC_MAXLRWDATA - EC_FIRSTDCDATAGRA] bytes in the process image, the first segmentsize will be zero instead and this cause the wrongly reading for the wkc from then incoming messages
|
I'd like to get some additional information to verify the fix |
|
Hi, here they are: |
|
Unfortunately the wireshark dump does not show how the fix should work. Slave 1 has an input size smaller than [EC_MAXLRWDATA - EC_FIRSTDCDATAGRAM] (1486 - 20). So everything works normal. Also I think the fix is incorrect. When having a first slave with a very large PDO size then the correct solution would be to remove the LRW datagram when the segment size = 0 (or replace it with a NOP datagram). |
|
This fix needs some re-work , please update and repost a proper fix as Arthur suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first slave has DC enabled and enouh PDOs to need more than [EC_MAXLRWDATA - EC_FIRSTDCDATAGRAM] bytes in the process image, the first segment's size will be zero instead of EC_FIRSTDCDATAGRAM and this cause the wrongly reading for the wkc at receiving time.