-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dark and light theme toggling with React context #1385
base: development
Are you sure you want to change the base?
Conversation
@huss I'm having a lot of fun with figuring out this issue (learning how to use React's context was really difficult but I get it now!), but I have two questions for you. No rush on answering, they're not immediately important.
Not a question, but I think the OED website's V1.0.0 documentation is missing a page for Language Settings. |
@tien-han Thanks for working on this and asking these questions.
I don't have it now but I think the art person who has helped before would be willing to do this. I'll start the process and let you know when it is done.
I have it all set up on my machine to capture the images correctly. Generally, the developer just notes there is a documentation change and I/the project makes it happen. In this case you simply put in a new link address (maybe darkmode/ in the help popup and then the page is created there. If you personally want to do it then we can discuss the details. It isn't too hard but there are some details. Also note we often delay updating the help until later because there may be other changes in how a page looks that is outside the work done.
Good catch. I found this last week when working with someone. PR #1383 is supposed to fix the few links that were off. The page is there but the location moved for all pages with the website update. It is hoped to be reviewed relatively soon (someone has agreed to review it) and then it should be added into OED. |
…ling for dark mode
Thank you @huss! Re: Help Page (Heads up that I'll be updating the checkboxes in the PR description to show progress.) |
Description
This PR implements "theme" toggling, better known as light/dark mode toggling. Dark mode has become a standard option for many websites and products, this change aims to bring this feature to OED.
Fixes #876
To Do's that have to be done before this PR is complete and ready to merge
Note: Fixing one item under a category will likely fix the rest of the items in that category (for "fixes").
Changes that need to be made
Single Drop Down Fixes
Multi-select Drop Down Fixes
Calendar Fixes
Input Field Fixes
Card Fixes
Note: To select the dark mode title coloring, I used this online tool to find a darker shade: https://colorkit.co/color/add8e6/
Type of change
Checklist
Limitations
(Describe any issues that remain or work that should still be done.)