Fix user-facing misspelling, improve a few user-facing strings #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Missing letter. - Both '.json' and 'JSON' are used in other strings, but '.JSON' doesn't seem as clear. - Fixed capitalization and added verb to ensure the sentence is readable. I don't think that reproducing the error message exactly helps making it more readable in this case, because it is unlikely that people reading it will recognize the capitals in the middle of the sentence as an exact quote of some program's output.
|
Looks great, thanks @gonzalo-bulnes ! It's less time to review a single a PR, so a single PR is a bit better, but we don't mind small batches either. Up to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes three user-facing strings. One of them is an obvious misspelling, the other two are improvements for consistency and overall readability for end-users. (Details in commit message.)
I noticed these as I was browsing the translations in Weblate. I haven't finished my first pass, though. Do you prefer that I open a PR with small batches like this one as I go, or in this case to wait for me to finish reading all the strings? (With the caveat that that may take a little while.)
As I get more familiar with the precise context in which strings are used, I may have suggestions to improve source strings (e.g. to make them easier to translate, some structures happen to be more complex than other in general), but I don't expect that to be a significant volume.