Fix error shadowing in log when plugin fails to load #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't find a standard way of unwrapping the error, short of printing an entire stack trace. I don't think printing a stack trace in a log is useful, so I decided to print the error.__cause__ explicitly. Since there is always one single level of nesting in this code, I think that's OK. See https://docs.python.org/3/library/exceptions.html
|
I think this would be fine, thanks for the PR. If you want to make it a single error message, you could use: logger.warning("Failed to instantiate plugin {}: {}".format(dir, e.__cause__ if e.__cause__ is not None else e))? |
|
I think that's a better option! I'll amend the commit. 👍 |
|
Wait, sorry, no. If the plugin is indeed a core plugin, but an error happens when loading it, then only printing So I think it's probably best to keep both. What do you think @pierotofy ? |
|
Sounds good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1466
I don't think this is the ideal handling of the situation, because all log entries would contain two error messages. But I'm opening the PR for discussion.