Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10x volume calculations, base surface definitions. fix 3D vertical area measurements #1435

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

pierotofy
Copy link
Member

@pierotofy pierotofy commented Nov 14, 2023

This PR speeds up volume calculations using the measure tool by an order of magnitude. It also adds support for more options for base surface definition:

  • Triangulate (default), tassellates the input point set and interpolates linearly
  • Plane, fits a 3D plane minimizing the distance of the plane to all points in the set
  • Average, uses the mean Z of all points
  • Highest, uses the highest Z of all points
  • Lowest, uses the lowest Z of all points

image

This PR also removes grass-core as a dependency, which was an obstacle to a possible future port to native macOS.

It moves the changedetection and elevationmap plugins to https://github.com/OpenDroneMap/WebODM-Plugins-Archive. I don't know who is using these plugins, but they have dependencies to the grass code that is now removed. It should be possible to update the plugins by using the more up-to-date run_function_async function (instead of relying on the previously used grass context/engine), but will require some work. The plugins are in need of a maintainer.

@Saijin-Naib
Copy link
Contributor

Also makes rolling this up for Alpine a bit easier for me 🤓

This is quite an exciting rework!

@pierotofy
Copy link
Member Author

Fixes #1431

@pierotofy
Copy link
Member Author

Fixes #1421

@pierotofy pierotofy changed the title 10x volume calculations, base surface definitions 10x volume calculations, base surface definitions. fix 3D vertical area measurements Nov 14, 2023
@pierotofy pierotofy merged commit e8ae09b into OpenDroneMap:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants