[HELP WANTED] Maybe(?) fixes(?) regex #1793
Draft
+32
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
Compiler
wixoaGit
requested changes
May 17, 2024
| @@ -20,14 +20,15 @@ | |||
| src.flags = flags | |||
|
|
|||
| proc/Find(haystack, start = 1, end = 0) | |||
| return findtext(text, src, start, end) | |||
There was a problem hiding this comment.
The runtime replaces this proc with the native proc found in DreamProcNativeRegex.cs so this doesn't do anything.
| proc/Replace(haystack, replacement, start = 1, end = 0) | ||
| return replacetext(text, src, replacement, start, end) |
|
|
||
| proc/Replace_char(haystack, replacement, start = 1, end = 0) | ||
| set opendream_unimplemented = TRUE | ||
| return haystack |
Comment on lines
+15
to
+16
| state.GetArgument(1, "start").TryGetValueAsInteger(out int start); | ||
| state.GetArgument(2, "end").TryGetValueAsInteger(out int end); |
There was a problem hiding this comment.
It needs to be verified that these are both treated as 0 for non-integer values.
| return await RegexFind(state, state.Src, haystack, start, end); | ||
| } | ||
|
|
||
| public static async Task<DreamValue> RegexFind(AsyncNativeProc.State state, DreamObject regexInstance, DreamValue haystack, int start, int end) { |
There was a problem hiding this comment.
Why async? I don't see anything in here that is asynchronous.
There was a problem hiding this comment.
I just copied this from RegexReplace, not gonna lie!
| int start = bundle.GetArgument(2, "Start").MustGetValueAsInteger(); //1-indexed | ||
| int end = bundle.GetArgument(3, "End").MustGetValueAsInteger(); //1-indexed | ||
| if(!needleArg.TryGetValueAsString(out var needle)) | ||
| return DreamValue.True; |
There was a problem hiding this comment.
BYOND returns different values for different combinations of invalid arguments. Are those still replicated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is basically a shot in the dark. I believe that
regex.Find()was broken when it was a global regex. Also impliments proper regex functionality forfindtext()andreplacetext()