Lint for redundant positional arguments.

[moonheart08]

Fixes #1768, adds a new lint.

Warning OD2210 at code/modules/gamemaster/actions/atmos_leak.dm:20:45: The argument at index 1 is a positional argument with a redundant index (`1 = value` at argument 1). This does not function like a named argument and is likely a mistake.
Warning OD2210 at code/modules/gamemaster/actions/atmos_leak.dm:21:24: The argument at index 2 is a positional argument with a redundant index (`2 = value` at argument 2). This does not function like a named argument and is likely a mistake.
Warning OD2210 at code/modules/gamemaster/actions/atmos_leak.dm:22:21: The argument at index 3 is a positional argument with a redundant index (`3 = value` at argument 3). This does not function like a named argument and is likely a mistake.

[moonheart08]

this accidentally depends on #1767 and im too lazy to fix it merge that first.

[ike709]

Unit tests plz

[wixoaGit]

I'd also like for there to be unit tests. You can make one by #pragma-ing the lint to an error and purposefully triggering it.

[wixoaGit]

Unnecessary empty line

Suggested change

[wixoaGit]

Unnecessary empty line & parentheses

Suggested change

	if ((!expr.ValType.IsAnything && !paramType.MatchesType(expr.ValType))) {
	if (!expr.ValType.IsAnything && !paramType.MatchesType(expr.ValType)) {

[wixoaGit]

We avoid using backticks in compiler messages due to it causing formatting issues when pasted elsewhere

Suggested change

	$"The argument at index {argIndex + 1} is a positional argument with a redundant index (`{argIndex + 1} = value` at argument {argIndex + 1}). This does not function like a named argument and is likely a mistake.");
	$"The argument at index {argIndex + 1} is a positional argument with a redundant index (\"{argIndex + 1} = value\" at argument {argIndex + 1}). This does not function like a named argument and is likely a mistake.");