Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop image overlays with null/blank icon state from inheriting icons #1480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

out-of-phaze
Copy link
Contributor

As far as I know, a blank image new /image added as an overlay shouldn't inherit the parent's icon. It should only do that if you add a raw icon state as an overlay, like "foo".

@wixoaGit
Copy link
Member

wixoaGit commented Oct 10, 2023

I tried usr.overlays |= new /image(null, "arrow") in BYOND, and it did create an overlay with the arrow state and usr's icon. A null or empty icon_state did not use the default, however.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@out-of-phaze
Copy link
Contributor Author

I tried usr.overlays |= new /image(null, "arrow") in BYOND, and it did create an overlay with the arrow state and usr's icon. A null or empty icon_state did not use the default, however.

Huh, I held off on touching this PR because I assumed mirroring this functionality would require changes, but... I think that's what it does in this PR as is. Good to know.

@out-of-phaze out-of-phaze changed the title Stop blank image overlays from inheriting icons Stop image overlays with null/blank icon state from inheriting icons Dec 4, 2023
@wixoaGit
Copy link
Member

I tried usr.overlays |= new /image(null, "arrow") in BYOND, and it did create an overlay with the arrow state and usr's icon. A null or empty icon_state did not use the default, however.

Huh, I held off on touching this PR because I assumed mirroring this functionality would require changes, but... I think that's what it does in this PR as is. Good to know.

That is not what this PR does. Using a line like what I gave does not add a visible overlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants