S90volume.sh : also store headphones volume #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful, because the minimum volume is very loud when only PCM is adjustable. Signed-off-by: Christophe Branchereau <[email protected]>
|
I actually disagree about this. A user who, for some reason, have a very low or muted Headphones volume (e.g. by toying with the "alsamixergui" without knowing anything about it) may not be able to fix it without asking for help, and rebooting wouldn't fix the problem. I think the way to go would be to have pwswd's volume backend to support more than one gain control. Then rising the volume from muted would first unmute Headphones and PCM (both at minimal gain value), then raise Headphones, and when Headphones is at 100, it would raise PCM. Then and only then storing both PCM and Headphones volume would be acceptable. |
pcercuei
pushed a commit
that referenced
this pull request
Sep 30, 2021
mtod()-related buffer overflows (CVE-2021-3592 #44, CVE-2021-3593 #45, CVE-2021-3594 #47, CVE-2021-3595 #46). Drop patch (already in version) https://gitlab.freedesktop.org/slirp/libslirp/-/blob/v4.6.1/CHANGELOG.md Signed-off-by: Fabrice Fontaine <[email protected]> Signed-off-by: Thomas Petazzoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful, because the minimum volume is very loud when only PCM is adjustable.
Kept the old format and just added one line for Headphones below, to ensure a smooth transition that keeps users settings.
Signed-off-by: Christophe Branchereau [email protected]