Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile #12

Open
wants to merge 1 commit into
base: opendingux
Choose a base branch
from
Open

Dockerfile #12

wants to merge 1 commit into from

Conversation

Kukunin
Copy link

@Kukunin Kukunin commented May 31, 2020

Add Dockerfile to build docker images

@pcercuei
Copy link
Member

Please squash the commits, then sign-off the result (git commit -s), then I'll merge it.

@Kukunin
Copy link
Author

Kukunin commented Jul 4, 2020

Hi @pcercuei sorry for the delay. I want to test the dockerfiles so it works, then I'll build the latest docker images and will push it the PR as you wanted (a single signed commit)

Signed-off-by: Sergiy Kukunin <[email protected]>
@Kukunin
Copy link
Author

Kukunin commented May 13, 2021

I've finished this PR after a year ) However, I have a couple of concerns.
The Dockerfile contains only toolchain, which I believe might be useful in some cases. The main advantage over archived toolchains is that it has all build dependencies installed. However, if one builds a lot, it's still better to configure the toolchain and all dependencies once on a host.

Having the toolchain residing in Docker wouldn't make buildroot build faster since it still needs to compile a lot of stuff. Frankly, I even don't know how to leverage the outside toolchain for buildroot, and how much time it would save.

I thought about keeping compiled objects in a docker image, so one shouldn't compile the whole buildroot if he needs to make a change. But all compiled objects are about 15gb, so I doubt it's too much more convenient to download 15gb over building for hours.

Anyway, it's the first step, and I believe it's still worth including in the repo so others can leverage Docker and working Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants