Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

od: use -O3 #114

Open
wants to merge 1 commit into
base: opendingux
Choose a base branch
from
Open

od: use -O3 #114

wants to merge 1 commit into from

Conversation

glebm
Copy link

@glebm glebm commented Jan 25, 2023

No description provided.

@SnDream
Copy link

SnDream commented Feb 10, 2023

Here are the results of my test.
-O3: can keep gambatte running Mental Respirator at full speed with frameskip.
-fipa-pta: one scene in Mental Respirator has sound flickering, but it looks better than without this parameter (personal subjective feeling).

PS: Dingoonity was closed recently, where else can I get more information about OpenDingux?

@glebm
Copy link
Author

glebm commented Feb 10, 2023

So I guess we should go with #112, which has both -O3 and -fipa-pta (LTO has no effect as it only affects a few irrelevant packages).
While most system packages make no difference, I'm guessing the main speedup comes from SDL being compiled with these flags.

@glebm
Copy link
Author

glebm commented Feb 10, 2023

PS: Dingoonity was closed recently, where else can I get more information about OpenDingux?

I'm guessing you're on the Discord already but in case you're not: https://discord.gg/t7GeHScr

@glebm
Copy link
Author

glebm commented Feb 18, 2023

Rebased, so now the build in this PR has both -fipa-pta and -O3

@glebm
Copy link
Author

glebm commented Mar 18, 2023

@pcercuei Let's merge this?

@glebm
Copy link
Author

glebm commented Mar 18, 2023

Actually, shall we enable this for all systems, not just the rs90?

Improves performance in emulators, e.g. Gambatte on the RS90.

Signed-off-by: Gleb Mazovetskiy <[email protected]>
@glebm
Copy link
Author

glebm commented Mar 18, 2023

Now enabled on all systems, similar to #115

@glebm glebm changed the title od: rs90: use -O3 od: use -O3 Mar 18, 2023
@pcercuei
Copy link
Member

Can we have more tests with various games / apps, and emulators that don't use dynarecs (e.g. PocketSNES)?

@glebm
Copy link
Author

glebm commented Mar 18, 2023

This doesn't change the compilation flags for emulators nor the kernel, just the buildroot packages. The improvement likely comes from SDL. So I'm guessing SDL blitting functions get more optimized or something like that.

I don't have 2 devices to run side-by-side, if someone does please do test! 🙏

@citral23
Copy link

citral23 commented Jun 6, 2023

I haven't been able to measure any meaningful difference between just -fipa-pta and -fipa-pta + -O3, neither on the rs90 nor a rg350m

It's possible the difference seen was unrelated to -O3, it's after all rather doubtful that it would introduce a dramatic improvement at blitting, that's not generally how things work (it barely does anything, or even worsens emulators perfs, so I doubt OS itself would have a clear benefit personnally)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants