Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeatbeatProducer and Node are moved on creation #403

Open
thirtytwobits opened this issue Nov 23, 2024 · 0 comments
Open

HeatbeatProducer and Node are moved on creation #403

thirtytwobits opened this issue Nov 23, 2024 · 0 comments
Labels
class-requirement Issue that can be traced back to a design requiement domain-production Pertains to the shippable code rather than any scaffolding priority-low A minor issue

Comments

@thirtytwobits
Copy link
Contributor

thirtytwobits commented Nov 23, 2024

There are several problems leading to multiple HeartbeatProducer and Node move constructor invocations on startup. The first is returning instances for functions returning variants. Instead the cetl::pf17::in_place_type constructors should be used (e.g. node.hpp:60). After this, the heartbeat producer is moved again into the node immediately after it was created. This triggers setting up then tearing down nodes in the AVL graph (i.e. this is not trivial). We need a way to instantiate a node without move-constructing the producers used.

@pavel-kirienko pavel-kirienko added priority-low A minor issue domain-production Pertains to the shippable code rather than any scaffolding class-requirement Issue that can be traced back to a design requiement labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class-requirement Issue that can be traced back to a design requiement domain-production Pertains to the shippable code rather than any scaffolding priority-low A minor issue
Projects
None yet
Development

No branches or pull requests

2 participants