-
Notifications
You must be signed in to change notification settings - Fork 2
Add support for Symfony 7 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also update dev & qa tooling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work again!
Suggestions:
- Maybe add an entry in the
CHANGELOG.md? - Run the ci/cd tests on PHP 8.4?
| "symfony/http-kernel": "^5.4|^6.3", | ||
| "symfony/twig-bridge": "^5.4|^6.3", | ||
| "symfony/validator": "^5.4|^6.3" | ||
| "surfnet/stepup-saml-bundle": "dev-feature/maintenance_nov-25", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder: Make sure this is removed before tagging a new version of the bundle.
✔️ |
MKodde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with the promise that you will install the correct SAML bundle version before merging this :)
Also update dev & qa tooling.