Skip to content

Conversation

@johanib
Copy link

@johanib johanib commented Nov 6, 2025

Also update dev & qa tooling.

Also update dev & qa tooling.
@johanib johanib marked this pull request as ready for review November 10, 2025 10:01
@johanib johanib requested a review from MKodde November 10, 2025 10:01
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again!

Suggestions:

  1. Maybe add an entry in the CHANGELOG.md?
  2. Run the ci/cd tests on PHP 8.4?

"symfony/http-kernel": "^5.4|^6.3",
"symfony/twig-bridge": "^5.4|^6.3",
"symfony/validator": "^5.4|^6.3"
"surfnet/stepup-saml-bundle": "dev-feature/maintenance_nov-25",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: Make sure this is removed before tagging a new version of the bundle.

- Update changelog and readme
- Add docheader check
- reinstate phpcpd
@johanib
Copy link
Author

johanib commented Nov 11, 2025

Nice work again!

Suggestions:

  1. Maybe add an entry in the CHANGELOG.md?
  2. Run the ci/cd tests on PHP 8.4?

✔️
Also updated the readme as it was targeted at old Symfony versions.

@johanib johanib requested a review from MKodde November 13, 2025 13:58
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the promise that you will install the correct SAML bundle version before merging this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants