Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automated registry #7

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: automated registry #7

wants to merge 11 commits into from

Conversation

gjj
Copy link
Contributor

@gjj gjj commented Jul 3, 2020

In this MR, we demonstrate the usage of Google Sheets as an alternative registry storage, instead of the static registry.json.

Key changes:

  • Since an API key is needed to access the Google Sheets data, OpenCertsVerificationManagerOptions now extends VerificationManagerOptions in OpenAttestation to include googleApiKey, so that it can be used in the registryVerifier.verify() method.

    • Rationale: (a) did not want to hardcode the Google API key for obvious reasons, (b) registry is OC-specific, so I'm adding this here instead of the OA library
  • Added GoogleSpreadsheetValues to follow the spreadsheets.values API

Temporary changes (will be reverted):

  • Added dist files so that the feature branch on opencerts-websites can build properly

@lgtm-com
Copy link

lgtm-com bot commented Jul 3, 2020

This pull request introduces 2 alerts when merging 2d0bb90 into b6df22d - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2020

This pull request introduces 1 alert when merging e22c132 into 3094dcc - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request introduces 1 alert when merging a32c8c5 into 3094dcc - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@gjj gjj force-pushed the feat/automated-registry branch from a32c8c5 to f7c9f36 Compare July 7, 2020 03:22
@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request introduces 1 alert when merging f7c9f36 into 3094dcc - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request introduces 1 alert when merging 7c17601 into 3094dcc - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request introduces 1 alert when merging 2871a5f into 3094dcc - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant