[CI] Add container build #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@Renizmy Thanks a lot for your contribution !
I have added some questions and changes to do.
And to move forward, we also need to create an image with rolling tag, could you add these changes too on the file ?
| name: Build opencti/python-client | ||
| command: | | ||
| docker run --privileged --rm tonistiigi/binfmt --install all | ||
| CIRCLE_TAG=${CIRCLE_TAG:-nightly} |
There was a problem hiding this comment.
@Renizmy Thank you for this PR, could you explain this ? What is the purpose of CIRCLE_TAG:-nightly ?
| --build-arg BASE_IMAGE="python:3.12-alpine3.20" | ||
|
|
||
| - run: | ||
| name: Push image to regsitry |
There was a problem hiding this comment.
Could you correct the naming ?
Suggested change
| name: Push image to regsitry | |
| name: Push image to registry |
| --build-arg BASE_IMAGE="python:3.11-alpine3.20" | ||
|
|
||
| - run: | ||
| name: Push image to regsitry |
There was a problem hiding this comment.
Could you correct the naming ?
Suggested change
| name: Push image to regsitry | |
| name: Push image to registry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a Connector Base Image (WIP 🚧)
Required environment variables for docker registry connection
DOCKERHUB_PASSDOCKERHUB_USERNAMECompleted Tasks
Pending Tasks