Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for token based auth for PCS #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for token based auth for PCS #15

wants to merge 1 commit into from

Conversation

cjh1
Copy link
Member

@cjh1 cjh1 commented Mar 19, 2025

No description provided.

@synackd synackd changed the title Add support for token based auth Add support for token based auth for PCS Mar 19, 2025
@synackd
Copy link
Collaborator

synackd commented Mar 19, 2025

Thanks for this. I updated the title to reflect that this is for the pcs command. Is this ready for testing?

@cjh1
Copy link
Member Author

cjh1 commented Mar 19, 2025

Thanks for this. I updated the title to reflect that this is for the pcs command. Is this ready for testing?

yes

@cjh1
Copy link
Member Author

cjh1 commented Mar 19, 2025

To test you would have to define PCS_JWKS_URL in the PCS environment ...

@cjh1
Copy link
Member Author

cjh1 commented Mar 19, 2025

I just added it to docker-compose.test.ct.yml and added the quickstart_internal to the networks, so it could reach out the opaal from the quickstart setup.

@synackd
Copy link
Collaborator

synackd commented Mar 20, 2025

Do you have a patch you could share for the testing changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjh1 @synackd