Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/endpoint-history: Support PostgreSQL #44

Merged
merged 10 commits into from
Aug 8, 2024

Conversation

synackd
Copy link
Collaborator

@synackd synackd commented Aug 5, 2024

Introduces one of multiple fixes for #20.

Modify the /endpoint-history endpoint to support PostgreSQL, not just EtcD.

@synackd synackd added the not ready Not ready to merge label Aug 5, 2024
@synackd synackd self-assigned this Aug 5, 2024
@synackd synackd force-pushed the postgres-endpoint-history branch from 962b027 to f28d550 Compare August 5, 2024 22:52
@synackd synackd force-pushed the postgres-endpoint-history branch from f28d550 to a6f2c0a Compare August 6, 2024 00:39
@synackd synackd removed the not ready Not ready to merge label Aug 6, 2024
@synackd synackd marked this pull request as ready for review August 6, 2024 23:31
Copy link
Contributor

@davidallendj davidallendj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it didn't crash, so I'd say it's working.

@synackd
Copy link
Collaborator Author

synackd commented Aug 8, 2024

Thanks @davidallendj. I've done some preliminary testing on two clusters (including booting nodes and querying the endpoint) and it works as expected.

@synackd synackd merged commit 7445d83 into OpenCHAMI:main Aug 8, 2024
1 check passed
@synackd synackd deleted the postgres-endpoint-history branch August 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants