Fix build and add GitHub actions workflow #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaeHagen
requested changes
Apr 14, 2025
Collaborator
TaeHagen
left a comment
TaeHagen
left a comment
There was a problem hiding this comment.
Mostly looks good, a few changes requested.
Collaborator
|
Please note your contribution will be accepted under the MPL license, NOT the LGPL. Upstream changed their license a while back, I never rebased for just that commit, but now it's here too. |
TaeHagen
reviewed
Apr 15, 2025
omnisette/Cargo.toml
Outdated
| remote-anisette = [] | ||
| async = ["dep:async-trait"] | ||
| default = ["remote-anisette", "dep:remove-async-await", "async"] | ||
| default = ["remote-anisette-v3", "dep:remove-async-await", "async"] |
Collaborator
There was a problem hiding this comment.
If I try to use clearadi, it does not compile, because remote-anisette-v3 is enabled. I cannot disable it, because icloud-auth always uses omnisette's default features. Either remove remote-anisette-v3 as a default feature, or make icloud-auth not use omnisette's default features.
Collaborator
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.