Add function to create ions from AMBER templates #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple functions for creating Na+ and Cl- ions using AMBER template files. The idea is to use these in BioSimSpace and SOMD2 to provide templates for alchemical ion pertubations. For example, something like:
The ion information is so minimal that we could probably store the template another way if we wished to preserve space. This just mimics the approach used for the water topologies and gives the option of using parameters optimised for the typical water models that we use (can add more in future). I could also consolidate the two functions to call a common
_pvt_create_ion
function, or similar. However, they were so short that I didn't think it was worth the effort.devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods