-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[Feature] Support Python 3.13 #7193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, the 3.13 part looks good. I would like to ask for the rationale to move the built python interfaces from openbb to openbb_core. This technically doesn't de-bloat the package, but instead actually introduces more "dead code" to the core for those who operate minimalist deployments or custom extensions.
The rationale is that the build script not being part of I'm not sure if "dead code" is the correct analogy, if one was just utilizing the Python interface, all of the API interface code is essentially "dead code". If it ships with no static assets, then those files will only get populated if, and when, the Python interface is imported or built. One feature of If you disagree, or want to reserve judgement for later, we can scope it out. Just feels like a decent time to make this kind of move. |
This PR adds support across all packages and dependencies for Python 3.13.
Additionally, it moves the
openbb
folder to inside thecore
package and updates the references to these folders. This ensures that the build script ships when onlyopenbb-core
is installed.I have not yet encountered anything requiring syntax modifications, and bumped package versions are still compatible with 3.9.
Testing done:
openbb-build
process.