Fix gocycle in chain.go #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhugelianglongming
force-pushed
the
dev-gocycle_chain
branch
from
f7b4258
to
0214a76
Compare
godeamon
reviewed
Feb 16, 2023
| @@ -115,24 +116,18 @@ func (t *Chain) Context() *common.ChainCtx { | |||
| } | |||
|
|
|||
| // 交易预执行 | |||
| func (t *Chain) PreExec(ctx xctx.XContext, reqs []*protos.InvokeRequest, initiator string, authRequires []string) (*protos.InvokeResponse, error) { | |||
| func (t *Chain) PreExec(ctx xctx.XContext, reqs []*protos.InvokeRequest, initiator string, | |||
There was a problem hiding this comment.
这个接口改完本地跑过 reserved contract 相关测试吗
There was a problem hiding this comment.
本地跑的测试相当于是 reserved contract 为空的环境
现在 5.* 一般如何在测试/本地环境 测试 reserved contract ？看代码好像没有给 put 的更新接口。
There was a problem hiding this comment.
godeamon
reviewed
Feb 16, 2023
gaoweibupt
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #402
kernel/engines/xuperos/chain.go
Line 118: warning: cyclomatic complexity 23 of function (*Chain).PreExec() is high (> 15) (gocyclo)