Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUST CSE] Access array elements before Cross border inspection #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blueothershore
Copy link
Contributor

DeviceClass_t devClass = MacCtx.NvmCtx->MulticastChannelList[groupID].ChannelParams.Class;
Before executing this line of code, we'd better first check if the array is out of bounds, rather than placing a check after this line of code.
Code modification: Swap the code position to advance the check for array out of bounds to the front of array access

@tencent-adm
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@blueothershore blueothershore marked this pull request as ready for review April 20, 2023 09:39
@blueothershore blueothershore changed the title Access array elements before Cross border inspection [HUST CSE] Access array elements before Cross border inspection Apr 21, 2023
@blueothershore
Copy link
Contributor Author

可否拜托review一下(拜托🙏)

@Supowang1989
Copy link
Collaborator

Supowang1989 commented Apr 25, 2023

这个修改可能需要意法半导体的工程师介入了,LoRaWAN协议是集成在厂商的BSP里面
或者需要看下semtech官方是否处理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants