Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused logo file from "Hello OpenAssetIO" notebook #89

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

feltech
Copy link
Member

@feltech feltech commented Apr 10, 2024

Closes #85. The logo file in the hello_openassetio resources directory was the deliberately misspelled logo from the querying_entity_versions notebook. Also, the logo file itself is never used within the notebook.

So remove the logo file, and use an obvious dummy path to the logo for exemplification purposes instead.

@feltech feltech self-assigned this Apr 10, 2024
@feltech feltech requested a review from a team as a code owner April 10, 2024 11:03
@feltech feltech changed the title [Examples] Remove unused logo file from Hello OpenAssetIO [Examples] Remove unused logo file from "Hello OpenAssetIO" notebook Apr 10, 2024
@feltech feltech changed the title [Examples] Remove unused logo file from "Hello OpenAssetIO" notebook Remove unused logo file from "Hello OpenAssetIO" notebook Apr 10, 2024
@feltech feltech force-pushed the work/removeLogoFromHelloExample branch 2 times, most recently from bc061f0 to da1b8d1 Compare April 10, 2024 16:00
@elliotcmorris
Copy link
Contributor

elliotcmorris commented Apr 10, 2024

Path is relative errors on the new URL in tests. ... I wonder if we can be more descriptive about this, I got it a lot doing the BAL work and it's hard for the layperson to understand what about the path makes it relative, as it's often to do with the leading slashes.

Closes OpenAssetIO#85. The logo file in the `hello_openassetio` resources directory
was the deliberately misspelled logo from the `querying_entity_versions`
notebook. Also, the logo file itself is never used within the notebook.

So remove the logo file, and use an obvious dummy path to the logo for
exemplification purposes instead.

Signed-off-by: David Feltell <[email protected]>
@feltech feltech force-pushed the work/removeLogoFromHelloExample branch from da1b8d1 to e0a8f97 Compare April 11, 2024 09:12
@feltech
Copy link
Member Author

feltech commented Apr 11, 2024

Path is relative errors on the new URL in tests. ... I wonder if we can be more descriptive about this, I got it a lot doing the BAL work and it's hard for the layperson to understand what about the path makes it relative, as it's often to do with the leading slashes.

It's tricky to find a URL/path that works cross-platform. file:///c:/path actually works on both platforms, but /c:/path doesn't "look right" on POSIX. So now I've (force-) pushed an update that pins to PathType.kPOSIX.

There are a few places where we could be more specific about the reason for it being parsed as a relative path (see usages of kErrorRelativePath). Would involve updating every test in the massive test database, though, so it's not a 2 min change.

@feltech feltech merged commit b356f0e into OpenAssetIO:main Apr 11, 2024
27 checks passed
@feltech feltech deleted the work/removeLogoFromHelloExample branch April 11, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Typo in OpenAssetIO logo file used in the examples
2 participants