Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Long Windows paths in FilePathUrlConverter notebook #81

Conversation

feltech
Copy link
Member

@feltech feltech commented Feb 22, 2024

Part of OpenAssetIO/OpenAssetIO#1257. The
FilePathUrlConverter.pathFromUrl function now converts long Windows file URLs, which exceed the Windows MAX_PATH limit, to UNC device paths.

@feltech feltech self-assigned this Feb 22, 2024
@feltech feltech added the documentation Improvements or additions to documentation label Feb 22, 2024
@feltech
Copy link
Member Author

feltech commented Feb 22, 2024

Note that this has a depdenency on OpenAssetIO/OpenAssetIO#1269. Tests pass without the changes in that PR because there are no assertions of the output (it just prints).

Part of OpenAssetIO/OpenAssetIO#1257. The
`FilePathUrlConverter.pathFromUrl` function now converts long Windows
file URLs, which exceed the Windows `MAX_PATH` limit, to UNC device
paths.

Signed-off-by: David Feltell <[email protected]>
@feltech feltech force-pushed the work/OpenAssetIO-1257-pathToUrlWindowsMaxPath branch from d9bd6ca to ab811a3 Compare February 22, 2024 15:00
@feltech feltech requested a review from hutchinson February 22, 2024 15:09
@feltech feltech marked this pull request as ready for review February 22, 2024 15:10
@feltech feltech requested a review from a team as a code owner February 22, 2024 15:10
@feltech feltech merged commit 3b37d32 into OpenAssetIO:main Feb 23, 2024
26 checks passed
@feltech feltech deleted the work/OpenAssetIO-1257-pathToUrlWindowsMaxPath branch February 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants