[Tests] Add missing fixtures for API compliance suite #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feltech
force-pushed
the
work/fixMissingAPIComplianceFixtures
branch
from
96b855f to
47b461b
Compare
A couple of `initialize` tests can now support fixtures. For some time we only had one setting for BAL, so presumably that was why some tests were legitimately skipped(?) Though some tests were clearly skipped in error, and one test simply doesn't exist in the API compliance suite (`test_when_settings_expanded_then_manager_settings_updated`). One of the `getWithRelationship[s][Paged]` test cases was entirely missing fixtures, which was clearly a mistake. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/fixMissingAPIComplianceFixtures
branch
from
47b461b to
d93fc59
Compare
elliotcmorris
approved these changes
Aug 8, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of
initializetests can now support fixtures. For some time we only had one setting for BAL, so presumably that was why some tests were legitimately skipped(?) Though some tests were clearly skipped in error, and one test simply doesn't exist in the API compliance suite (test_when_settings_expanded_then_manager_settings_updated).One of the
getWithRelationship[s][Paged]test cases was entirely missing fixtures, which was clearly a mistake.