[Build] Bump OpenAssetIO to 1.0.0-beta.2.2 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered during OpenAssetIO/OpenAssetIO#1311. Since OpenAssetIO#84, BAL's tests make use of the newer `getWithRelationship` signatures and so fail if OpenAssetIO 1.0.0-beta.2.1 or earlier is installed. This isn't an incompatibility in BAL itself, just its tests. We could either: * Rewrite the tests to use the older API. * Bump the minimum supported version of OpenAssetIO * Ignore the failure, since it's only tests. Ignoring the test failure is potentially dangerous, in case the expected failure is masking a real issue. Rewriting the tests would be the best option, but requires development effort. Given that we're still in beta, the low-effort choice of bumping the minimum OpenAssetIO version seems the best pragmatic option. Signed-off-by: David Feltell <[email protected]>
foundry-markf
approved these changes
Jul 26, 2024
Hopefully not, I don't think there's anything planned in the near term that will break the manager API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during OpenAssetIO/OpenAssetIO#1311.
Since #84, BAL's tests make use of the newer
getWithRelationshipsignatures and so fail if OpenAssetIO 1.0.0-beta.2.1 or earlier is installed.This isn't an incompatibility in BAL itself, just its tests. We could either:
Ignoring the test failure is potentially dangerous, in case the expected failure is masking a real issue.
Rewriting the tests would be the best option, but requires development effort. Given that we're still in beta, the low-effort choice of bumping the minimum OpenAssetIO version seems the best pragmatic option.