Merge pull request #117 from feltech/work/allowUnknownSettings

Allow `initialize` with unrecognized settings
OpenAssetIO · Jul 19, 2024 · 465795f · 465795f
2 parents fb8456c + a914f98
commit 465795f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/plugin/openassetio_manager_bal/BasicAssetLibraryInterface.py b/plugin/openassetio_manager_bal/BasicAssetLibraryInterface.py
@@ -688,8 +688,6 @@ def __validate_settings(settings: dict):
         Parses the supplied settings dict, raising if there are any
         unrecognized keys present.
         """
-        defaults = BasicAssetLibraryInterface.__make_default_settings()
-
         if SETTINGS_KEY_LIBRARY_PATH in settings:
             if not isinstance(settings[SETTINGS_KEY_LIBRARY_PATH], str):
                 raise ValueError(f"{SETTINGS_KEY_LIBRARY_PATH} must be a str")
@@ -715,10 +713,6 @@ def __validate_settings(settings: dict):
                     "legal URL scheme characters (a-z, A-Z, 0-9, -)"
                 )
 
-        for key in settings:
-            if key not in defaults:
-                raise KeyError(f"Unknown setting '{key}'")
-
 
 class BALEntityReferencePagerInterface(EntityReferencePagerInterface):
     """

diff --git a/tests/fixtures.py b/tests/fixtures.py
@@ -105,12 +105,6 @@
                 "entity_reference_url_scheme": "thingy",
             }
         },
-        "test_when_settings_have_invalid_keys_then_all_settings_unchanged": {
-            "some_settings_with_new_values_and_invalid_keys": {"library_path": "", "cat": True}
-        },
-        "test_when_settings_have_invalid_keys_then_raises_KeyError": {
-            "some_settings_with_new_values_and_invalid_keys": {"library_path": "", "cat": True}
-        },
         "test_when_settings_have_subset_of_keys_then_other_settings_unchanged": {
             "some_settings_with_a_subset_of_keys": {"simulated_query_latency_ms": 2}
         },