Skip to content

modify build.py to produce installers#858

Merged
abrichr merged 8 commits into
mainfrom
feat/installer
Jul 19, 2024
Merged

modify build.py to produce installers#858
abrichr merged 8 commits into
mainfrom
feat/installer

Conversation

@abrichr

@abrichr abrichr commented Jul 17, 2024

Copy link
Copy Markdown
Member

We would like to implement automatic updates. Without installing to a system directory, however, this is not user friendly (see #782 (comment)).

This PR implements functionality to produce an installer so that the installed application can be updated more easily.

@abrichr abrichr requested a review from KIRA009 July 17, 2024 19:39
@KIRA009

KIRA009 commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

This looks good, tested on Mac. We might also have to change the ci scripts, unless the dmg making process is using stuff that comes pre-installed with the mac image

@abrichr

abrichr commented Jul 18, 2024

Copy link
Copy Markdown
Member Author

Thank you @KIRA009 !

We might also have to change the ci scripts, unless the dmg making process is using stuff that comes pre-installed with the mac image.

Can you please clarify?

Edit: Understood, I believe hdiutil is included in the standard MacOS installation. I've modified the CI scripts to remove zipping as well.

@abrichr

abrichr commented Jul 19, 2024

Copy link
Copy Markdown
Member Author

@KIRA009 I believe we should modify the Github actions to remove the zipping functionality, since Inno Setup already seems to compress the setup file, and I believe .dmg files are also compressed. What do you think?

Edit: we will also need to modify the website to point to these new files.

@abrichr abrichr merged commit 21e5de1 into main Jul 19, 2024
@abrichr abrichr deleted the feat/installer branch July 19, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants