Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursorReplay #820

Closed
wants to merge 2 commits into from
Closed

cursorReplay #820

wants to merge 2 commits into from

Conversation

Ahmadkhan02
Copy link

@Ahmadkhan02 Ahmadkhan02 commented Jul 2, 2024

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

@Ahmadkhan02
Copy link
Author

Hi @abrichr , I was a bit confused and had some questions regarding the issue.

  1. Should self correction and adding a red dot be seperate action_events? or can do do drawing of red dot and return self correction as the action event (current implementation)
  2. I have no idea as to what action_event should be returned. Should the strategy return either red dot drawing event or self correction event depending on the state?
  3. Does capability for playback etc for drawing red dot ?

I am not quite able to frame questions well enough to clear my doubts. It would be quite helpful if you could give me an idea as to how this strategy would be used and whats expected from it. I get the stuff about mimicing the workflow of humans solving mathematics as an example but wanted to know how we need that here.

@Ahmadkhan02 Ahmadkhan02 marked this pull request as ready for review July 4, 2024 20:49
@abrichr
Copy link
Member

abrichr commented Jul 5, 2024

Hi @Ahmadkhan02 , thank you for your interest!

Should self correction and adding a red dot be seperate action_events? or can do do drawing of red dot and return self correction as the action event (current implementation)

Adding a red dot should not involve any action_events.

I have no idea as to what action_event should be returned. Should the strategy return either red dot drawing event or self correction event depending on the state?

The only action_event(s) that should be returned are the ones that should be played back on the user's machine in order to accomplish their instructions.

I recommend starting with an easier task. This one appears to be close to solved in #823.

@Ahmadkhan02 Ahmadkhan02 closed this by deleting the head repository Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants