Skip to content

fix: Add option to update OpenAdapt app#765

Closed
mobley-trent wants to merge 4 commits into
OpenAdaptAI:mainfrom
mobley-trent:autoupdate
Closed

fix: Add option to update OpenAdapt app#765
mobley-trent wants to merge 4 commits into
OpenAdaptAI:mainfrom
mobley-trent:autoupdate

Conversation

@mobley-trent

@mobley-trent mobley-trent commented Jun 17, 2024

Copy link
Copy Markdown

What kind of change does this PR introduce?

A fix that enables the OpenAdapt app to update on launch

Summary

Fixes #755
/claim #755

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

Comment thread openadapt/start.py
@mobley-trent mobley-trent marked this pull request as ready for review June 19, 2024 11:54
@mobley-trent mobley-trent requested a review from abrichr June 19, 2024 12:04
@mobley-trent

Copy link
Copy Markdown
Author

@abrichr I implemented two shell scripts to handle the downloads in both windows and macos. I added the option to run the script in openadapt/app/main.py under ui.icon("update").

I had some trouble building the application since I am running on Linux. I hope you could help me test if the feature is working.

@mobley-trent mobley-trent changed the title fix: Automatic update on launch fix: Add option to update OpenAdapt app Jun 19, 2024
@abrichr

abrichr commented Jun 19, 2024

Copy link
Copy Markdown
Member

Thank you for your contribution @mobley-trent !

Typically how applications handle this is to say something like:

A new version is available: vxx.xx.xx (you are on vyy.yy.yy). Would you like to update? Yes/No/Skip this version

We can show a message on startup indicating that a new version is available, and let the user decide how to proceed.

If you're on Linux it will be tricky to test this out. I suggest either implementing Linux support:

#144

Or using something like https://www.virtualbox.org/

@abrichr

abrichr commented Jun 20, 2024

Copy link
Copy Markdown
Member

@mobley-trent thank you for putting this together. All else equal I prefer to keep as much as possible in python rather than platform-specific scripts. #782 has implemented it this way.

Unfortunately we can only award the bounty to one PR, and while that one is not yet merged, I think it is closer than this one (owing to the fact that it is implemented in Python, and the author is able to test it out). Just letting you know in case there is another issue you might like to address instead of this one.

Thanks again! 🙏

@mobley-trent

Copy link
Copy Markdown
Author

Thanks for your patience all through @abrichr 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement automatic updates

2 participants