Audio narration #673
Merged
Audio narration #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vely convert reqd properties to str
KIRA009
force-pushed
the
feature/audio-narration
branch
from
e1fb56d to
61d01c6
Compare
|
Thanks @KIRA009 ! I tried running a recording with this, but it seems to hang: 
Any suggestions? |
|
@abrichr It could possibly be because the first time the model is downloaded it takes some time, how long was it in this state? |
KIRA009
force-pushed
the
feature/audio-narration
branch
from
405ac48 to
4f99f00
Compare
~5min before I killed it. Upon trying again I am no longer experiencing this issue, and the recording completes, modulo this exception: However, when running (I have run |
|
@abrichr my fault. I manually added the |
|
@KIRA009 when pressing ctrl+c during recording I get this: I believe we need to follow this pattern used elsewhere in record.py: After adding this, I no longer get the error, but the process hangs: 
|
…er in audio recording process
KIRA009
force-pushed
the
feature/audio-narration
branch
from
f2f400e to
4ef3ea5
Compare
|
@KIRA009 I'm unable to start the recording: After manually deleting the lock file: It looks like there are two issues:
|
|
After recreating the database, I no longer get the database error. However, I do still get the lock error, and have to manually delete it. Also, after stopping the cording with ctrl+c: The terminal appears to hang after this line: After a couple of minutes I press ctrl+c again and from the stack trace it appears to be hanging on |
|
I think we may need to run this on startup: Not sure where to put this. |
abrichr
reviewed
May 30, 2024
openadapt/db/crud.py
Outdated
| @@ -816,8 +817,14 @@ def acquire_db_lock(timeout: int = 60) -> bool: | |||
| logger.error("Failed to acquire database lock.") | |||
| return False | |||
| if os.path.exists(DATA_DIR_PATH / "database.lock"): | |||
| logger.info("Database is locked. Waiting...") | |||
| time.sleep(1) | |||
| with open(DATA_DIR_PATH / "database.lock", "r") as lock_file: | |||
There was a problem hiding this comment.
It appears that this path is re-used in several places. What do you think about defining it in config.py?
|
@KIRA009 we could merge this as-is. However ideally we would integrate The reason is for the additional instrumentation (performance and logging). What do you think? |
7 tasks
R-ohit-B-isht
pushed a commit
to R-ohit-B-isht/OpenAdapt
that referenced
this pull request
Jun 21, 2024
* feat: Add audio narration feature while recording * feat: Remove implicit scrubbing in display_event function and recursively convert reqd properties to str * feat: Add transcribed text to dashboard visualisation * feat: Use recording id as foreign key, and add interrupt signal handler in audio recording process * feat: Check if the lock is stale when acquiring locks * refactor: Convert database lock path to a constant in config file --------- Co-authored-by: Richard Abrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds the ability to record audio when recording actions.
Summary
This is a cleaned up and updated PR, taken from #346 . This adds a new process which records the audio narrated by the user while recording, then transcribes it using openai's whisper model, and saves relevant information to the database. A follow up PR would display the transcribed text along with the actions during which they were narrated.
Checklist
How can your code be run and tested?
Other information